linux-kernel - Re: [PATCH] media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+UFZBM2bon3qogsq1az4fD0PW3-O2LJgLZ7Uf0zVsw6Q@mail.gmail.com>
Date:   Sun, 22 Oct 2023 15:59:16 -0500
From:   Rob Herring <robh@...nel.org>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias"

On Sun, Oct 22, 2023 at 3:17 PM Laurent Pinchart
<laurent.pinchart@...asonboard.com> wrote:
>
> Hi Rob,
>
> Thank you for the patch.
>
> On Fri, Oct 20, 2023 at 12:02:24PM -0500, Rob Herring wrote:
> > Every DT property needs a type defined, but "i2c-alias" is missing any
> > type definition. It's a "uint32", so add a type reference.
> >
> > Fixes: 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
> > Signed-off-by: Rob Herring <robh@...nel.org>
>
> This is something I should have paid more attention when reviewing the
> bindings. I'll try to keep it in mind for the future.

No need, the tools will check for you now. :)

But the same property defined multiple times is not yet checked

> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Thanks.

Rob