linux-kernel - Re: [PATCH] apparmor: mark new functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <528363d9-bf39-401d-b696-a034917a4610@canonical.com>
Date:   Sun, 22 Oct 2023 00:46:48 -0700
From:   John Johansen <john.johansen@...onical.com>
To:     Arnd Bergmann <arnd@...nel.org>, Paul Moore <paul@...l-moore.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Georgia Garcia <georgia.garcia@...onical.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Khadija Kamran <kamrankhadijadj@...il.com>,
        Casey Schaufler <casey@...aufler-ca.com>,
        Christian Brauner <brauner@...nel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] apparmor: mark new functions static

On 10/20/23 06:12, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Two new functions were introduced as global functions when they are
> only called from inside the file that defines them and should have
> been static:
> 
> security/apparmor/lsm.c:658:5: error: no previous prototype for 'apparmor_uring_override_creds' [-Werror=missing-prototypes]
> security/apparmor/lsm.c:682:5: error: no previous prototype for 'apparmor_uring_sqpoll' [-Werror=missing-prototypes]
> 
> Fixes: c4371d90633b7 ("apparmor: add io_uring mediation")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: John Johansen <john.johansen@...onical.com>

I have pulled this into apparmor-next

> ---
>   security/apparmor/lsm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index 91ff91cf1aaef..4981bdf029931 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -655,7 +655,7 @@ static int profile_uring(struct aa_profile *profile, u32 request,
>    * Check to see if the current task is allowed to override it's credentials
>    * to service an io_uring operation.
>    */
> -int apparmor_uring_override_creds(const struct cred *new)
> +static int apparmor_uring_override_creds(const struct cred *new)
>   {
>   	struct aa_profile *profile;
>   	struct aa_label *label;
> @@ -679,7 +679,7 @@ int apparmor_uring_override_creds(const struct cred *new)
>    * Check to see if the current task is allowed to create a new io_uring
>    * kernel polling thread.
>    */
> -int apparmor_uring_sqpoll(void)
> +static int apparmor_uring_sqpoll(void)
>   {
>   	struct aa_profile *profile;
>   	struct aa_label *label;