[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231022111153.GB800259@ZenIV>
Date: Sun, 22 Oct 2023 12:11:53 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: David Laight <David.Laight@...lab.com>
Cc: Eric Dumazet <edumazet@...gle.com>,
gus Gusenleitner Klaus <gus@...a.com>,
Al Viro <viro@....linux.org.uk>,
Thomas Gleixner <tglx@...utronix.de>,
lkml <linux-kernel@...r.kernel.org>,
Ingo Molnar <mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>,
"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
"x86@...nel.org" <x86@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
"dsahern@...nel.org" <dsahern@...nel.org>,
"kuba@...nel.org" <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>
Subject: Re: AW: [PATCH] amd64: Fix csum_partial_copy_generic()
On Sun, Oct 22, 2023 at 11:03:39AM +0000, David Laight wrote:
> > + return -1;
>
> If you are going to return -1 the return type should be signed.
It's a perfectly valid C to have return -1 in a function that
returns unsigned long long (or any other unsigned type, really)...
Powered by blists - more mailing lists