linux-kernel - Re: [PATCH v11 02/16] KVM: x86: Use a new flag for branch targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTadZtriaQeKHksJ@google.com>
Date:   Mon, 23 Oct 2023 09:20:54 -0700
From:   Sean Christopherson <seanjc@...gle.com>
To:     Binbin Wu <binbin.wu@...ux.intel.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        pbonzini@...hat.com, chao.gao@...el.com, kai.huang@...el.com,
        David.Laight@...lab.com, robert.hu@...ux.intel.com,
        guang.zeng@...el.com
Subject: Re: [PATCH v11 02/16] KVM: x86: Use a new flag for branch targets

On Wed, Sep 13, 2023, Binbin Wu wrote:
> Use the new flag X86EMUL_F_BRANCH instead of X86EMUL_F_FETCH in assign_eip()
> to distinguish instruction fetch and branch target computation for features
> that handle differently on them, e.g. Linear Address Space Separation (LASS).

A slightly different shortlog+changelog:

  KVM: x86: Add an emulator flag to differntiate branch targets from fetches

  Add an emulator flag, X86EMUL_F_BRANCH, and use it instead of
  X86EMUL_F_FETCH in assign_eip() to distinguish between instruction fetch
  and branch target computation for features that handle them differently,
  e.g. Intel's upcoming Linear Address Space Separation (LASS) applies to
  code fetches but not branch target calculations.

The shortlog in particular is far too vague.

> As of this patch, X86EMUL_F_BRANCH and X86EMUL_F_FETCH are identical as far
> as KVM is concerned.

This patch looks good, but I'm going to skip it for now as it's not needed until
LASS is supported, since LAM doesn't differentiate between the two.  I.e. this
should have been the first patch in the LASS portion of the series.  No need to
repost, it's trivially easy to tweak vmx_get_untagged_addr().