[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6786c91e-12ce-a9dd-12fe-bc02c6d782b8@linaro.org>
Date: Mon, 23 Oct 2023 19:39:49 +0200
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Lukasz Luba <lukasz.luba@....com>, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org, rafael@...nel.org
Cc: dietmar.eggemann@....com, rui.zhang@...el.com,
amit.kucheria@...durent.com, amit.kachhap@...il.com,
viresh.kumar@...aro.org, len.brown@...el.com, pavel@....cz,
mhiramat@...nel.org, qyousef@...alina.io, wvw@...gle.com
Subject: Re: [PATCH v4 04/18] PM: EM: Refactor em_pd_get_efficient_state() to
be more flexible
On 25/09/2023 10:11, Lukasz Luba wrote:
> The Energy Model (EM) is going to support runtime modification. There
> are going to be 2 EM tables which store information. This patch aims
> to prepare the code to be generic and use one of the tables. The function
> will no longer get a pointer to 'struct em_perf_domain' (the EM) but
> instead a pointer to 'struct em_perf_state' (which is one of the EM's
> tables).
>
> Prepare em_pd_get_efficient_state() for the upcoming changes and
> make it possible to re-use. Return an index for the best performance
> state for a given EM table. The function arguments that are introduced
> should allow to work on different performance state arrays. The caller of
> em_pd_get_efficient_state() should be able to use the index either
> on the default or the modifiable EM table.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@....com>
> ---
[ ... ]
> @@ -251,7 +253,9 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
> * Find the lowest performance state of the Energy Model above the
> * requested frequency.
> */
> - ps = em_pd_get_efficient_state(pd, freq);
> + i = em_pd_get_efficient_state(pd->table, pd->nr_perf_states, freq,
> + pd->flags);
nitpicking but s/i/state/
Other than that:
Reviewed-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> + ps = &pd->table[i];
>
> /*
> * The capacity of a CPU in the domain at the performance state (ps)
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists