linux-kernel - Re: [PATCH v1 2/2] jffs2: make cleanmarker support option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <406915015.32119.1698083084288.JavaMail.zimbra@nod.at>
Date:   Mon, 23 Oct 2023 19:44:44 +0200 (CEST)
From:   Richard Weinberger <richard@....at>
To:     Martin Kurbanov <mmkurbanov@...utedevices.com>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Christian Brauner <brauner@...nel.org>,
        Dave Chinner <dchinner@...hat.com>,
        Yu Zhe <yuzhe@...china.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        kernel <kernel@...rdevices.ru>
Subject: Re: [PATCH v1 2/2] jffs2: make cleanmarker support option

----- Ursprüngliche Mail -----
> Von: "Martin Kurbanov" <mmkurbanov@...utedevices.com>
> If you disable the cleanmarker, the found clean block (filled with 0xff)
> will be erased again (see fs/jffs2/scan.c#L162).
> In my opinion, it is better to perform the block erasure again than to
> not work with such a nand flash at all.

Doesn't this case many re-erases at each mount time?

BTW: I tried your patch in nandsim, jffs2 was unhappy.
[   56.147361] jffs2: notice: (440) jffs2_build_xattr_subsystem: complete building xattr subsystem, 0 of xdatum (0 unchecked, 0 orphan) and 0 of xref (0 dead, 0 orphan) found.
[   56.200438] nand: nand_do_write_ops: attempt to write non page aligned data
[   56.201090] jffs2: Write clean marker to block at 0x001f8000 failed: -22

Do you have an idea?

Thanks,
//richard