[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231023181457.GI691768@ziepe.ca>
Date: Mon, 23 Oct 2023 15:14:57 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: sharmaajay@...uxonhyperv.com
Cc: Long Li <longli@...rosoft.com>, Leon Romanovsky <leon@...nel.org>,
Dexuan Cui <decui@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, linux-rdma@...r.kernel.org,
linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Ajay Sharma <sharmaajay@...rosoft.com>
Subject: Re: [Patch v7 1/5] RDMA/mana_ib: Rename all mana_ib_dev type
variables to mib_dev
On Mon, Oct 16, 2023 at 03:11:58PM -0700, sharmaajay@...uxonhyperv.com wrote:
> From: Ajay Sharma <sharmaajay@...rosoft.com>
>
> This patch does not introduce any functional changes. It
> creates naming convention to distinguish especially when
> used in the same function.Renaming all mana_ib_dev type
> variables to mib_dev to have clean separation between
> eth dev and ibdev variables.
> Signed-off-by: Ajay Sharma <sharmaajay@...rosoft.com>
> ---
> drivers/infiniband/hw/mana/cq.c | 12 ++--
> drivers/infiniband/hw/mana/device.c | 34 +++++------
> drivers/infiniband/hw/mana/main.c | 87 ++++++++++++++--------------
> drivers/infiniband/hw/mana/mana_ib.h | 9 +--
> drivers/infiniband/hw/mana/mr.c | 29 +++++-----
> drivers/infiniband/hw/mana/qp.c | 84 +++++++++++++--------------
> drivers/infiniband/hw/mana/wq.c | 21 +++----
> 7 files changed, 141 insertions(+), 135 deletions(-)
Please no, don't create pointless giant churn like this. It only hurts
backporters
Maybe just target the functions with more than one type
Jason
Powered by blists - more mailing lists