linux-kernel - Re: [PATCH] KEYS: Clean up errors in key.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Oct 2023 22:59:35 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     <chenguohua@...i.cn>, <dhowells@...hat.com>
Cc:     <keyrings@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KEYS: Clean up errors in key.h

On Thu Oct 12, 2023 at 12:06 PM EEST,  wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: GuoHua Cheng <chenguohua@...i.cn>

So what was the patch?

> ---
>  include/linux/key.h | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/include/linux/key.h b/include/linux/key.h
> index 938d7ecfb495..48a43c9efaed 100644
> --- a/include/linux/key.h
> +++ b/include/linux/key.h
> @@ -503,18 +503,18 @@ extern void key_init(void);
>  #define key_validate(k)			0
>  #define key_serial(k)			0
>  #define key_get(k) 			({ NULL; })
> -#define key_revoke(k)			do { } while(0)
> -#define key_invalidate(k)		do { } while(0)
> -#define key_put(k)			do { } while(0)
> -#define key_ref_put(k)			do { } while(0)
> +#define key_revoke(k)			do { } while (0)
> +#define key_invalidate(k)		do { } while (0)
> +#define key_put(k)			do { } while (0)
> +#define key_ref_put(k)			do { } while (0)
>  #define make_key_ref(k, p)		NULL
>  #define key_ref_to_ptr(k)		NULL
>  #define is_key_possessed(k)		0
> -#define key_fsuid_changed(c)		do { } while(0)
> -#define key_fsgid_changed(c)		do { } while(0)
> -#define key_init()			do { } while(0)
> -#define key_free_user_ns(ns)		do { } while(0)
> -#define key_remove_domain(d)		do { } while(0)
> +#define key_fsuid_changed(c)		do { } while (0)
> +#define key_fsgid_changed(c)		do { } while (0)
> +#define key_init()			do { } while (0)
> +#define key_free_user_ns(ns)		do { } while (0)
> +#define key_remove_domain(d)		do { } while (0)
>  
>  #endif /* CONFIG_KEYS */
>  #endif /* __KERNEL__ */

BR, Jarkko