[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZTcFhmdAPL0LQD7J@fedora>
Date: Tue, 24 Oct 2023 07:45:10 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Jens Axboe <axboe@...nel.dk>
Cc: linux-block@...r.kernel.org, Tejun Heo <tj@...nel.org>,
linux-kernel@...r.kernel.org, Juri Lelli <juri.lelli@...hat.com>,
Andrew Theurer <atheurer@...hat.com>,
Joe Mario <jmario@...hat.com>,
Sebastian Jug <sejug@...hat.com>,
Frederic Weisbecker <frederic@...nel.org>, ming.lei@...hat.com
Subject: Re: [PATCH V2] blk-mq: don't schedule block kworker on isolated CPUs
On Fri, Oct 13, 2023 at 08:47:58PM +0800, Ming Lei wrote:
> Kernel parameter of `isolcpus=` or 'nohz_full=' are used for isolating CPUs
> for specific task, and user often won't want block IO to disturb these CPUs,
> also long IO latency may be caused if blk-mq kworker is scheduled on these
> isolated CPUs.
>
> Kernel workqueue only respects this limit for WQ_UNBOUND, for bound wq,
> the responsibility should be on wq user.
>
> So don't not run block kworker on isolated CPUs by ruling out isolated CPUs
> from hctx->cpumask. Meantime in cpuhp handler, use queue map to check if
> all CPUs in this hw queue are offline, this way can avoid any cost in fast
> IO code path.
>
> Cc: Juri Lelli <juri.lelli@...hat.com>
> Cc: Andrew Theurer <atheurer@...hat.com>
> Cc: Joe Mario <jmario@...hat.com>
> Cc: Sebastian Jug <sejug@...hat.com>
> Cc: Frederic Weisbecker <frederic@...nel.org>
> Signed-off-by: Ming Lei <ming.lei@...hat.com>
> ---
> V2:
> - remove module parameter, meantime use queue map to check if
> all cpus in one hctx are offline
Hello Guys,
Ping...
Thanks,
Ming
Powered by blists - more mailing lists