linux-kernel - Re: [PATCH] mtd: block2mtd: Add a valid holder to blkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231023054413.GA11272@lst.de>
Date:   Mon, 23 Oct 2023 07:44:13 +0200
From:   Christoph Hellwig <hch@....de>
To:     Richard Weinberger <richard@....at>
Cc:     linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        vigneshr@...com, miquel.raynal@...tlin.com, joern@...ybastard.org,
        Christoph Hellwig <hch@....de>, stable@...r.kernel.org
Subject: Re: [PATCH] mtd: block2mtd: Add a valid holder to blkdev_put()

On Sat, Oct 21, 2023 at 08:58:32PM +0200, Richard Weinberger wrote:
> Since commit 2736e8eeb0ccd ("block: use the holder as indication for exclusive opens")

Overly long line here.

> blkdev_put() requires a valid holder argument.
> So, do so also in block2mtd to unbreak bdev->bd_holder refcounting.


Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>