linux-kernel - Re: [PATCH 09/11] iio: adc: Update QCOM ADC drivers for bindings path change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2dc93e2b-61b4-943c-f938-296922fbece4@quicinc.com>
Date:   Mon, 23 Oct 2023 11:47:37 +0530
From:   Jishnu Prakash <quic_jprakash@...cinc.com>
To:     Jonathan Cameron <jic23@...nel.org>
CC:     <agross@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linus.walleij@...aro.org>,
        <Jonathan.Cameron@...wei.com>, <sboyd@...nel.org>,
        <dmitry.baryshkov@...aro.org>, <quic_subbaram@...cinc.com>,
        <quic_collinsd@...cinc.com>, <quic_kamalw@...cinc.com>,
        <marijn.suijten@...ainline.org>,
        <andriy.shevchenko@...ux.intel.com>,
        <krzysztof.kozlowski@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        <linux-arm-msm@...r.kernel.org>, <linux-iio@...r.kernel.org>,
        <linux-arm-msm-owner@...r.kernel.org>
Subject: Re: [PATCH 09/11] iio: adc: Update QCOM ADC drivers for bindings path
 change

Hi Jonathan,

On 7/8/2023 8:53 PM, Jonathan Cameron wrote:
> On Sat, 8 Jul 2023 12:58:33 +0530
> Jishnu Prakash <quic_jprakash@...cinc.com> wrote:
>
>> Update ADC dt-bindings file paths in QCOM ADC driver files to
>> match the dt-bindings change moving the files from 'iio' to
>> 'iio/adc' folder.
>>
>> Signed-off-by: Jishnu Prakash <quic_jprakash@...cinc.com>
> Do the move in one go.
>
> Diff rename detection will make the resulting patch more trivial
> to look at than this multistep version.
>
> Jonathan

Hi Jonathan,

Just to recap, in patches 8-11, the intention is to move the dt-binding 
files used for QCOM ADCs from /dt-bindings/iio folder to the 
/dt-bindings/iio/adc folder.

I'm just confirming, can we move the files and update documentation, 
bindings, driver and devicetree files all in one patch? Or you mean one 
patch for documentation, bindings and driver files and one patch for 
devicetree files (based on the comment from Krzysztof for the next patch 
10 in this series)?

Based on this patch series: 
https://lore.kernel.org/all/cover.1646388139.git.zong.li@sifive.com/, 
I'm wondering if I should add the files in the new location first, do 
the file path updates and then completely remove the files in the old 
path to avoid breaking the kernel.....or is it possible to get the 
devicetree changes picked along with the binding changes, to avoid any 
problems with bisectability?

>> ---
>>   drivers/iio/adc/qcom-spmi-adc5-gen3.c | 2 +-
>>   drivers/iio/adc/qcom-spmi-adc5.c      | 2 +-
>>   drivers/iio/adc/qcom-spmi-vadc.c      | 2 +-
>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>
Thanks,

Jishnu