[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <06d27457-6b6c-4392-9be1-d1fecfbfd9f3@proton.me>
Date: Mon, 23 Oct 2023 07:01:28 +0000
From: Benno Lossin <benno.lossin@...ton.me>
To: Alice Ryhl <alice@...l.io>
Cc: Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Alice Ryhl <aliceryhl@...gle.com>,
Andreas Hindborg <nmi@...aspace.dk>,
rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
Miguel Ojeda <ojeda@...nel.org>,
Wedson Almeida Filho <wedsonaf@...il.com>,
Alex Gaynor <alex.gaynor@...il.com>
Subject: Re: [PATCH v2] rust: macros: improve `#[vtable]` documentation
On 21.10.23 14:45, Alice Ryhl wrote:
> On 10/19/23 19:15, Benno Lossin wrote:
>> Traits marked with `#[vtable]` need to provide default implementations
>> for optional functions. The C side represents these with `NULL` in the
>> vtable, so the default functions are never actually called. We do not
>> want to replicate the default behavior from C in Rust, because that is
>> not maintainable. Therefore we should use `build_error` in those default
>> implementations. The error message for that is provided at
>> `kernel::error::VTABLE_DEFAULT_ERROR`.
>>
>> Signed-off-by: Benno Lossin <benno.lossin@...ton.me>
>
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
>
> There is a minor nit below, and in reviews sent by others, but overall
> this looks fine to me.
>
>> /// # Examples
>> ///
>> /// ```ignore
>> +/// # use kernel::error::VTABLE_DEFAULT_ERROR;
>> /// use kernel::prelude::*;
> I probably wouldn't hide the import of VTABLE_DEFAULT_ERROR from this
> example.
What do you guys think of putting the const it in the prelude?
--
Cheers,
Benno
Powered by blists - more mailing lists