linux-kernel - Re: [PATCH 01/13] ASoC: amd: acp: Add acp6.3 pci legacy driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edeebfab-e26c-4c18-8126-190c3e834521@kernel.org>
Date:   Mon, 23 Oct 2023 10:01:35 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Syed Saba Kareem <Syed.SabaKareem@....com>, broonie@...nel.org,
        alsa-devel@...a-project.org
Cc:     Vijendar.Mukunda@....com, Basavaraj.Hiregoudar@....com,
        Sunil-kumar.Dommati@....com, mario.limonciello@....com,
        venkataprasad.potturu@....com, arungopal.kondaveeti@....com,
        mastan.katragadda@....com, juan.martinez@....com,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        V Sujith Kumar Reddy <vsujithkumar.reddy@....com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Jarkko Nikula <jarkko.nikula@...mer.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Yang Li <yang.lee@...ux.alibaba.com>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/13] ASoC: amd: acp: Add acp6.3 pci legacy driver
 support

On 21/10/2023 16:50, Syed Saba Kareem wrote:
> Add pci legacy driver support and create platform driver for
> acp6.3 based platforms.
> 
> Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@....com>
> ---
>  sound/soc/amd/acp/acp-legacy-common.c |   4 +
>  sound/soc/amd/acp/acp-pci.c           |   4 +
>  sound/soc/amd/acp/acp63.c             | 314 ++++++++++++++++++++++++++
>  sound/soc/amd/acp/amd.h               |   4 +
>  4 files changed, 326 insertions(+)
>  create mode 100644 sound/soc/amd/acp/acp63.c
> 


> +
> +static const struct dev_pm_ops acp63_dma_pm_ops = {
> +	SET_SYSTEM_SLEEP_PM_OPS(NULL, acp63_pcm_resume)
> +};
> +
> +static struct platform_driver acp63_driver = {
> +	.probe = acp63_audio_probe,
> +	.remove_new = acp63_audio_remove,
> +	.driver = {
> +		.name = "acp_asoc_acp63",
> +		.pm = &acp63_dma_pm_ops,
> +	},
> +};
> +
> +module_platform_driver(acp63_driver);
> +
> +MODULE_DESCRIPTION("AMD ACP acp63 Driver");
> +MODULE_IMPORT_NS(SND_SOC_ACP_COMMON);
> +MODULE_LICENSE("Dual BSD/GPL");
> +MODULE_ALIAS("platform:" DRV_NAME);

You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong.


Best regards,
Krzysztof