linux-kernel - Re: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host mlme.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874jih1zbu.fsf@kernel.org>
Date:   Mon, 23 Oct 2023 12:07:49 +0300
From:   Kalle Valo <kvalo@...nel.org>
To:     David Lin <yu-hao.lin@....com>
Cc:     Francesco Dolcini <francesco@...cini.it>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "briannorris@...omium.org" <briannorris@...omium.org>,
        Sharvari Harisangam <sharvari.harisangam@....com>,
        Pete Hsieh <tsung-hsien.hsieh@....com>
Subject: Re: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support
 host mlme.

David Lin <yu-hao.lin@....com> writes:

>> From: Francesco Dolcini <francesco@...cini.it>
>> Sent: Friday, October 20, 2023 11:25 PM
>> To: David Lin <yu-hao.lin@....com>
>> Cc: linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org;
>> briannorris@...omium.org; kvalo@...nel.org; francesco@...cini.it; Sharvari
>> Harisangam <sharvari.harisangam@....com>; Pete Hsieh
>> <tsung-hsien.hsieh@....com>
>> Subject: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host
>> mlme.
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On Fri, Oct 20, 2023 at 03:48:06AM +0000, David Lin wrote:
>> > Patch v6:
>> > Correct mailing sequence.
>>
>> You are still doing something wrong sending the patches over email, the
>> various emails are not threaded as expected, git-send-email should do
>> everything for you.
>>
>> No need to re-send now IMO, but please figure out what's wrong for the next
>> time.
>>
>> To give you an idea here [1] you see this email alone.
>>
>> This [2] and this [3] are examples of a properly sent patch series (just random
>> series from your NXP colleagues).
>>
>> You have also a winmail.dat file attached to every email in this series, not sure
>> what it is, but I would try to not send it.
>>
>
> Yes. I can send them as a single e-mail. However, I find other member
> would send multiple patches as separate e-mails with a cover letter. I
> think it would be easier for review.

We are not asking to send the patches as single email. We are asking to
run git send-email only _once_ per patchset to make sure threading is
correct (ie. References and In-Reply-to headers are set). For example,
you can do it like this:

$ git format-patch --base=auto --cover-letter -o outgoing/ main
outgoing/0000-cover-letter.patch
outgoing/0001-First-Commit.patch
outgoing/...

$ git send-email [...] outgoing/

More info:

https://wireless.wiki.kernel.org/en/developers/documentation/git-guide

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches