linux-kernel - Re: [PATCH] wifi: iwlwifi: Add check for kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <433af526223619beabad96a9003cad05c5b6189b.camel@sipsolutions.net>
Date:   Mon, 23 Oct 2023 11:10:04 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Kalle Valo <kvalo@...nel.org>, Chen Ni <nichen@...as.ac.cn>
Cc:     gregory.greenman@...el.com, mukesh.sisodiya@...el.com,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: iwlwifi: Add check for kmemdup

On Mon, 2023-10-23 at 12:08 +0300, Kalle Valo wrote:
> Chen Ni <nichen@...as.ac.cn> writes:
> 
> > Since the kmemdup may return NULL pointer,
> > it should be better to add check for the return value
> > in order to avoid NULL pointer dereference.
> > 
> > Fixes: 5e31b3df86ec ("wifi: iwlwifi: dbg: print pc register data once
> > fw dump occurred")
> 
> The fixes tag should be in one line.
> 

It's also irrelevant because (a) the fix is incorrect, and (b) we
already have a (correct) fix :)

johannes