linux-kernel - Re: [PATCH] tracefs/eventfs: Modify mismatched function name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ed5f20a5-52e5-9869-1a3f-576beb955f97@quicinc.com>
Date:   Mon, 23 Oct 2023 14:52:42 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        <rostedt@...dmis.org>
CC:     <mhiramat@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-trace-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] tracefs/eventfs: Modify mismatched function name



On 10/19/2023 8:43 AM, Jiapeng Chong wrote:
> No functional modification involved.
> 
> fs/tracefs/event_inode.c:864: warning: expecting prototype for eventfs_remove(). Prototype was for eventfs_remove_dir() instead.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6939
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Reviewed-by: Mukesh Ojha <quic_mojha@...cinc.com>

-Mukesh
> ---
>   fs/tracefs/event_inode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c
> index 1ccd100bc565..ba9d1cb0d24c 100644
> --- a/fs/tracefs/event_inode.c
> +++ b/fs/tracefs/event_inode.c
> @@ -855,7 +855,7 @@ static void unhook_dentry(struct dentry **dentry, struct dentry **list)
>   	}
>   }
>   /**
> - * eventfs_remove - remove eventfs dir or file from list
> + * eventfs_remove_dir - remove eventfs dir or file from list
>    * @ei: eventfs_inode to be removed.
>    *
>    * This function acquire the eventfs_mutex lock and call eventfs_remove_rec()