linux-kernel - Re: [PATCH 1/5] riscv: use ".L" local labels in assembly when applicable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231023-8397e25545716f7f168e9007@orel>
Date:   Mon, 23 Oct 2023 11:59:26 +0200
From:   Andrew Jones <ajones@...tanamicro.com>
To:     Clément Léger <cleger@...osinc.com>
Cc:     Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Anup Patel <anup@...infault.org>,
        Atish Patra <atishp@...shpatra.org>,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, kvm-riscv@...ts.infradead.org
Subject: Re: [PATCH 1/5] riscv: use ".L" local labels in assembly when
 applicable

On Wed, Oct 04, 2023 at 04:30:50PM +0200, Clément Léger wrote:
> For the sake of coherency, use local labels in assembly when
> applicable. This also avoid kprobes being confused when applying a
> kprobe since the size of function is computed by checking where the
> next visible symbol is located. This might end up in computing some
> function size to be way shorter than expected and thus failing to apply
> kprobes to the specified offset.
> 
> Signed-off-by: Clément Léger <cleger@...osinc.com>
> ---
>  arch/riscv/kernel/entry.S  | 10 +++----
>  arch/riscv/kernel/head.S   | 18 ++++++-------
>  arch/riscv/kernel/mcount.S | 10 +++----
>  arch/riscv/lib/memmove.S   | 54 +++++++++++++++++++-------------------
>  4 files changed, 46 insertions(+), 46 deletions(-)
>

Reviewed-by: Andrew Jones <ajones@...tanamicro.com>