linux-kernel - Re: [PATCH] tracing/histograms: Simplify last_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ed6de5e-5b47-30cb-68fa-ce6ee7c839a8@quicinc.com>
Date:   Mon, 23 Oct 2023 15:38:48 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>
CC:     <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/histograms: Simplify last_cmd_set()



On 10/21/2023 8:12 PM, Christophe JAILLET wrote:
> Turn a kzalloc()+strcpy()+strncat() into an equivalent and less verbose
> kasprintf().
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   kernel/trace/trace_events_hist.c | 11 ++---------
>   1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index d06938ae0717..1abc07fba1b9 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -774,23 +774,16 @@ static void last_cmd_set(struct trace_event_file *file, char *str)
>   {
>   	const char *system = NULL, *name = NULL;
>   	struct trace_event_call *call;
> -	int len;
>   
>   	if (!str)
>   		return;
>   
> -	/* sizeof() contains the nul byte */
> -	len = sizeof(HIST_PREFIX) + strlen(str);
>   	kfree(last_cmd);
> -	last_cmd = kzalloc(len, GFP_KERNEL);
> +
> +	last_cmd = kasprintf(GFP_KERNEL, HIST_PREFIX "%s", str);
>   	if (!last_cmd)
>   		return;
>   
> -	strcpy(last_cmd, HIST_PREFIX);
> -	/* Again, sizeof() contains the nul byte */
> -	len -= sizeof(HIST_PREFIX);
> -	strncat(last_cmd, str, len);

LGTM, careful optimization., Thanks.
Reviewed-by: Mukesh ojha <quic_mojha@...cinc.com>


-Mukesh

> -
>   	if (file) {
>   		call = file->event_call;
>   		system = call->class->system;