linux-kernel - RE: [EXT] Re: [PATCH] wifi: mwifiex: added delay after firmware downloaded.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PA4PR04MB96383AEDA0E0D42A11E5518AD1D8A@PA4PR04MB9638.eurprd04.prod.outlook.com>
Date:   Mon, 23 Oct 2023 02:12:46 +0000
From:   David Lin <yu-hao.lin@....com>
To:     Francesco Dolcini <francesco@...cini.it>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "briannorris@...omium.org" <briannorris@...omium.org>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        Sharvari Harisangam <sharvari.harisangam@....com>,
        Pete Hsieh <tsung-hsien.hsieh@....com>
Subject: RE: [EXT] Re: [PATCH] wifi: mwifiex: added delay after firmware
 downloaded.


> From: Francesco Dolcini <francesco@...cini.it>
> Sent: Saturday, October 21, 2023 8:56 PM
> To: David Lin <yu-hao.lin@....com>
> Cc: linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org;
> briannorris@...omium.org; kvalo@...nel.org; francesco@...cini.it; Sharvari
> Harisangam <sharvari.harisangam@....com>; Pete Hsieh
> <tsung-hsien.hsieh@....com>
> Subject: [EXT] Re: [PATCH] wifi: mwifiex: added delay after firmware
> downloaded.
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> Hello David,
> thanks for your patch.
> 
> On Fri, Oct 20, 2023 at 03:35:34AM +0000, David Lin wrote:
> > Added 100 ms delayed after firmware is downloaded and active in order
> > to avoid command timeout for the first command sent to firmware.
> 
> Please have a look at Documentation/process/submitting-patches.rst.
> In very brief:
>  - you should use imperative mood to describe your changes
>  - this is fixing a real issue, I believe this is worth a more complete commit
>    message, including a log of the failure this is solving.
> 
> I am also inclined to think that this change should be backported and it likely
> would need a Fixes: tag.
> 
> > ---
> >  drivers/net/wireless/marvell/mwifiex/main.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/wireless/marvell/mwifiex/main.c
> > b/drivers/net/wireless/marvell/mwifiex/main.c
> > index d99127dc466e..a25e8bb8daec 100644
> > --- a/drivers/net/wireless/marvell/mwifiex/main.c
> > +++ b/drivers/net/wireless/marvell/mwifiex/main.c
> > @@ -570,6 +570,7 @@ static int _mwifiex_fw_dpc(const struct firmware
> *firmware, void *context)
> >               goto err_dnld_fw;
> >
> >       mwifiex_dbg(adapter, MSG, "WLAN FW is active\n");
> > +     mdelay(100);
> 
> from my understanding there is already a function polling for the firmware to
> be active, e.g. mwifiex_check_fw_status(). Maybe is that function that needs
> to be fixed instead of adding an additional delay here?
> 

O.K. I will check the function to see if I can add this modification to the function.

> Francesco