linux-kernel - Re: [PATCH v4] padata: Fix refcnt handling in padata_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nqc5zfj5hjgk476o4iyehhmyadxvzjkz76ama72fzaasxjrpk3@liejkxexgg35>
Date:   Mon, 23 Oct 2023 09:58:29 -0400
From:   Daniel Jordan <daniel.m.jordan@...cle.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     WangJinchao <wangjinchao@...sion.com>,
        steffen.klassert@...unet.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, stone.xulei@...sion.com
Subject: Re: [PATCH v4] padata: Fix refcnt handling in padata_free_shell()

On Fri, Oct 20, 2023 at 01:03:59PM +0800, Herbert Xu wrote:
> WangJinchao <wangjinchao@...sion.com> wrote:
> > diff --git a/kernel/padata.c b/kernel/padata.c
> > index 222d60195de6..73108ac75f03 100644
> > --- a/kernel/padata.c
> > +++ b/kernel/padata.c
> > @@ -1102,12 +1102,15 @@ EXPORT_SYMBOL(padata_alloc_shell);
> >  */
> > void padata_free_shell(struct padata_shell *ps)
> > {
> > +       struct parallel_data *pd;
> >        if (!ps)
> >                return;

The \n after the declaration disappeared in this version but would be
nice for consistency with the file.  Maybe when applying, no need for
another post.

> Daniel, could you please reconfirm that you're still with v4?

Yes, regardless of above,
Acked-by: Daniel Jordan <daniel.m.jordan@...cle.com>