linux-kernel - Re: phy: fixed link 1000 or 100 set with autoneg off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Oct 2023 16:28:04 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     "Jia, Fang" <fang.jia@...driver.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: phy: fixed link 1000 or 100 set with autoneg off

> Thanks very much for your reply.
> 
> Actually, due to some reason, the phydev's default aneg state is off.
> And we just found if use ethtool to set, it had the same result.

I find it surprising it defaults to aneg off. Are you sure something
has not turned it off before you look at it?

The emulator does not support writing to any registers. However,
fixed_mdio_write() does not return an error, it just does nothing.  It
needs testing, but maybe try making it return -EOPNOTSUPP. That should
prevent auto-neg being turned off, but it might also break everything
if it tries to do some other write during probe or link up. It could
be it needs a more select response, allowing writes to some bits, like
the reset bit, and start auto-neg, but not others like disable
auto-neg.

	Andrew