linux-kernel - Re: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231024152708.GFZTfiTL9C6onZKn99@fat_crate.local>
Date:   Tue, 24 Oct 2023 17:27:08 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Jeshua Smith <jeshuas@...dia.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "james.morse@....com" <james.morse@....com>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "gpiccoli@...lia.com" <gpiccoli@...lia.com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        Thierry Reding <treding@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices

On Tue, Oct 24, 2023 at 04:32:48PM +0200, Rafael J. Wysocki wrote:
> So there are 3 designated reviewers for APEI: Tony Luck, Borislav
> Petkov and James Morse.  I need an ACK or Reviewed-by from one of
> them, so I can proceed with an APEI patch.

Here's what I see:

cat /tmp/patch | ./scripts/get_maintainer.pl
Kees Cook <keescook@...omium.org> (supporter:PSTORE FILESYSTEM)
Tony Luck <tony.luck@...el.com> (reviewer:PSTORE FILESYSTEM)
"Guilherme G. Piccoli" <gpiccoli@...lia.com> (reviewer:PSTORE FILESYSTEM)
"Rafael J. Wysocki" <rafael@...nel.org> (unknown:ACPI APEI)
Len Brown <lenb@...nel.org> (reviewer:ACPI APEI)
James Morse <james.morse@....com> (reviewer:ACPI APEI)
Borislav Petkov <bp@...en8.de> (reviewer:ACPI APEI)

so I'm guessing Kees, Tony, Guilherme ...

>From what I can see, the change itself is making me ask more questions:

When I see "may" in commit messages "Slow devices such as flash may not
meet the default 1ms timeout value" then I wanna know what devices are
those?

What is the actual use case here?

Upthread there's a question about the ACPI spec. That should be
explained too. Because I have no clue what "the ERST max execution time
value" is.

And so on.

HTH.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette