linux-kernel - Re: [PATCH] spmi: mediatek: Fix UAF on device remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c113be74d0ad1a7c94d313716e2fb8bd.sboyd@kernel.org>
Date:   Mon, 23 Oct 2023 19:01:36 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     James Lo <james.lo@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Yu-Che Cheng <giver@...omium.org>
Cc:     Yu-Che Cheng <giver@...omium.org>, Fei Shao <fshao@...omium.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] spmi: mediatek: Fix UAF on device remove

Quoting Yu-Che Cheng (2023-07-17 02:39:35)
> The pmif driver data that contains the clocks is allocated along with
> spmi_controller.
> On device remove, spmi_controller will be freed first, and then devres
> , including the clocks, will be cleanup.
> This leads to UAF because putting the clocks will access the clocks in
> the pmif driver data, which is already freed along with spmi_controller.
> 
> This can be reproduced by enabling DEBUG_TEST_DRIVER_REMOVE and
> building the kernel with KASAN.
> 
> Fix the UAF issue by using unmanaged clk_bulk_get() and putting the
> clocks before freeing spmi_controller.
> 
> Reported-by: Fei Shao <fshao@...omium.org>
> Signed-off-by: Yu-Che Cheng <giver@...omium.org>
> ---

Applied to spmi-next