linux-kernel - Re: [PATCH v2 iproute2-next 3/3] rdma: Adjust man page for rdma system set privileged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Oct 2023 11:04:47 -0600
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>,
        Patrisious Haddad <phaddad@...dia.com>
Cc:     jgg@...pe.ca, leon@...nel.org, stephen@...workplumber.org,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        linuxarm@...wei.com, linux-kernel@...r.kernel.org,
        huangjunxian6@...ilicon.com, michaelgur@...dia.com
Subject: Re: [PATCH v2 iproute2-next 3/3] rdma: Adjust man page for rdma
 system set privileged_qkey command

On 10/24/23 10:09 AM, Petr Machata wrote:
> 
> Patrisious Haddad <phaddad@...dia.com> writes:
> 
>> Signed-off-by: Patrisious Haddad <phaddad@...dia.com>
>> Reviewed-by: Michael Guralnik <michaelgur@...dia.com>
>> ---
>>  man/man8/rdma-system.8 | 32 +++++++++++++++++++++++++++-----
>>  1 file changed, 27 insertions(+), 5 deletions(-)
>>
>> diff --git a/man/man8/rdma-system.8 b/man/man8/rdma-system.8
>> index ab1d89fd..a2914eb8 100644
>> --- a/man/man8/rdma-system.8
>> +++ b/man/man8/rdma-system.8
>> @@ -23,16 +23,16 @@ rdma-system \- RDMA subsystem configuration
>>  
>>  .ti -8
>>  .B rdma system set
>> -.BR netns
>> -.BR NEWMODE
>> +.BR netns/privileged_qkey
>> +.BR NEWMODE/NEWSTATE
> 
> What is this netns/priveleged_qkey syntax? I thought they are
> independent options. If so, the way to express it is:
> 
> 	rdma system set [netns NEWMODE] [privileged_qkey NEWSTATE]
> 
> Also, your option is not actually privileged_qkey, but privileged-qkey.

yes, and the command lines below show 'privileged qkey'

> 
>>  .ti -8
>>  .B rdma system help
>>  
>>  .SH "DESCRIPTION"
>> -.SS rdma system set - set RDMA subsystem network namespace mode
>> +.SS rdma system set - set RDMA subsystem network namespace mode or privileged qkey mode
>>  
>> -.SS rdma system show - display RDMA subsystem network namespace mode
>> +.SS rdma system show - display RDMA subsystem network namespace mode and privileged qkey state
> 
> Maybe make it just something like "configure RDMA system settings" or
> whatever the umbrella term is? The next option will certainly have to do
> something, this doesn't scale.
> 
> Plus the lines are waaay over 80, even over 90 that I think I've seen
> Stephen or David mention as OK for iproute2 code.

a few over 80 is ok when it improves readability; over 90 (with the
exception of print strings) is unacceptable.