linux-kernel - Re: [PATCH v2 03/11] dt-bindings: leds: aw200xx: introduce optional hwen-gpios property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231024185415.oxj7f4ynomi7ldlq@CAB-WSD-L081021>
Date:   Tue, 24 Oct 2023 21:54:15 +0300
From:   Dmitry Rokosov <ddrokosov@...utedevices.com>
To:     Conor Dooley <conor@...nel.org>
CC:     <lee@...nel.org>, <pavel@....cz>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <andy.shevchenko@...il.com>, <kernel@...rdevices.ru>,
        <rockosov@...il.com>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-leds@...r.kernel.org>
Subject: Re: [PATCH v2 03/11] dt-bindings: leds: aw200xx: introduce optional
 hwen-gpios property

On Thu, Oct 19, 2023 at 03:11:06PM +0100, Conor Dooley wrote:
> On Wed, Oct 18, 2023 at 09:29:35PM +0300, Dmitry Rokosov wrote:
> > Property 'hwen-gpios' is optional, it can be used by the board
> > developer to connect AW200XX LED controller with appropriate poweron
> > GPIO pad.
> 
> If the pad is called "poweron", why is the property called "hwen"?
> 

I have just referred to GPIO as 'poweron gpio', which is my own figure
of speech. In actuality, this pin is officially referred to as 'hwen' in
the datasheet.

> > 
> > Signed-off-by: Dmitry Rokosov <ddrokosov@...utedevices.com>
> > ---
> >  Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> > index feb5febaf361..255eb0563737 100644
> > --- a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> > +++ b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> > @@ -41,6 +41,9 @@ properties:
> >      description:
> >        Leds matrix size
> >  
> > +  hwen-gpios:
> > +    maxItems: 1
> > +
> >  patternProperties:
> >    "^led@[0-9a-f]$":
> >      type: object
> > @@ -90,6 +93,7 @@ additionalProperties: false
> >  
> >  examples:
> >    - |
> > +    #include <dt-bindings/gpio/gpio.h>
> >      #include <dt-bindings/leds/common.h>
> >  
> >      i2c {
> > @@ -102,6 +106,7 @@ examples:
> >              #address-cells = <1>;
> >              #size-cells = <0>;
> >              awinic,display-rows = <3>;
> > +            hwen-gpios = <&gpio 3 GPIO_ACTIVE_HIGH>;
> >  
> >              led@0 {
> >                  reg = <0x0>;
> > -- 
> > 2.36.0
> > 



-- 
Thank you,
Dmitry