linux-kernel - Re: [PATCH] clk: si5351: Simplify probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05698f7e76734125ad06c52b9fc495fe.sboyd@kernel.org>
Date:   Mon, 23 Oct 2023 19:36:26 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Biju Das <biju.das.jz@...renesas.com>,
        Michael Turquette <mturquette@...libre.com>
Cc:     Biju Das <biju.das.jz@...renesas.com>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, Biju Das <biju.das.au@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] clk: si5351: Simplify probe()

Quoting Biju Das (2023-09-09 09:20:47)
> The driver has an OF match table, still, it uses an ID lookup table for
> retrieving match data. Currently, the driver is working on the
> assumption that an I2C device registered via OF will always match a
> legacy I2C device ID. The correct approach is to have an OF device ID
> table using i2c_get_match_data() if the devices are registered via OF/ID.
> 
> Simplify probe() by replacing ID lookup table for retrieving match data
> with i2c_get_match_data().
> 
> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> ---

Applied to clk-next