linux-kernel - Re: dm crypt: replace open-coded kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTg4GA005km7mmgC@redhat.com>
Date:   Tue, 24 Oct 2023 17:33:12 -0400
From:   Mike Snitzer <snitzer@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Alasdair Kergon <agk@...hat.com>, dm-devel@...ts.linux.dev,
        Justin Stitt <justinstitt@...gle.com>,
        linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: dm crypt: replace open-coded kmemdup_nul

On Tue, Oct 24 2023 at  5:18P -0400,
Kees Cook <keescook@...omium.org> wrote:

> On Mon, 25 Sep 2023 06:35:54 +0000, Justin Stitt wrote:
> > kzalloc() followed by strncpy() on an expected NUL-terminated string is
> > just kmemdup_nul(). Let's simplify this code (while also dropping a
> > deprecated strncpy() call [1]).
> > 
> > 
> 
> Applied to for-next/hardening, thanks!
> 
> [1/1] dm crypt: replace open-coded kmemdup_nul
>       https://git.kernel.org/kees/c/17348b0a6a6d
> 
> Take care,
> 
> -- 
> Kees Cook
> 

Hey,

I had picked up this patch and the 3 others in my local tree
yesterday, was going to push shortly... do you still want them to go
through your hardening tree?

Mike