linux-kernel - Re: [PATCH] clk: cdce925: Extend match support for OF tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f039e5c9c373710218dfd1e96a89d7b1.sboyd@kernel.org>
Date:   Mon, 23 Oct 2023 19:39:13 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Biju Das <biju.das.jz@...renesas.com>,
        Michael Turquette <mturquette@...libre.com>
Cc:     Biju Das <biju.das.jz@...renesas.com>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, Biju Das <biju.das.au@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] clk: cdce925: Extend match support for OF tables

Quoting Biju Das (2023-09-09 08:05:16)
> The driver has an OF match table, still, it uses an ID lookup table for
> retrieving match data. Currently, the driver is working on the
> assumption that an I2C device registered via OF will always match a
> legacy I2C device ID. The correct approach is to have an OF device ID
> table using i2c_get_match_data() if the devices are registered via OF/ID.
> 
> Unify the OF/ID table by using struct clk_cdce925_chip_info
> as match data for both these tables and replace the ID lookup table for
> the match data by i2c_get_match_data().
> 
> Split the array clk_cdce925_chip_info_tbl[] as individual variables, and
> make lines shorter by referring to e.g. &clk_cdce913_info instead of
> &clk_cdce925_chip_info_tbl[CDCE913].
> 
> Drop enum related to chip type as there is no user.
> 
> While at it, remove the trailing comma in the terminator entry for the OF
> table making code robust against (theoretical) misrebases or other similar
> things where the new entry goes _after_ the termination without the
> compiler noticing.
> 
> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> ---

Applied to clk-next