linux-kernel - Re: Possible bug report: kernel 6.5.0/6.5.1 high load when CIFS share is mounted (cifsd-cfid-laundromat in"D" state)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Oct 2023 21:51:21 -0500
From:   Steve French <smfrench@...il.com>
To:     Paulo Alcantara <pc@...guebit.com>
Cc:     "Dr. Bernd Feige" <bernd.feige@...klinik-freiburg.de>,
        "matoro_mailinglist_kernel@...oro.tk" 
        <matoro_mailinglist_kernel@...oro.tk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-cifs@...r.kernel.org" <linux-cifs@...r.kernel.org>,
        "bagasdotme@...il.com" <bagasdotme@...il.com>,
        "paul@...krain42.org" <paul@...krain42.org>,
        "tom@...pey.com" <tom@...pey.com>,
        "ronniesahlberg@...il.com" <ronniesahlberg@...il.com>,
        "bharathsm@...rosoft.com" <bharathsm@...rosoft.com>,
        "regressions@...ts.linux.dev" <regressions@...ts.linux.dev>,
        "brian.pardy@...il.com" <brian.pardy@...il.com>,
        "nspmangalore@...il.com" <nspmangalore@...il.com>
Subject: Re: Possible bug report: kernel 6.5.0/6.5.1 high load when CIFS share
 is mounted (cifsd-cfid-laundromat in"D" state)

We probably want this one as well ...

commit 2da338ff752a2789470d733111a5241f30026675
Author: Steve French <stfrench@...rosoft.com>
Date:   Tue Sep 19 11:35:53 2023 -0500

    smb3: do not start laundromat thread when dir leases
     disabled

    When no directory lease support, or for IPC shares where directories
    can not be opened, do not start an unneeded laundromat thread for
    that mount (it wastes resources).

    Fixes: d14de8067e3f ("cifs: Add a laundromat thread for cached directories")
    Reviewed-by: Paulo Alcantara (SUSE) <pc@...guebit.com>
    Acked-by: Tom Talpey <tom@...pey.com>
    Signed-off-by: Steve French <stfrench@...rosoft.com>



Any objections to adding that one to the list as well?  The patches
all seem to apply fine to current 6.5-stable-rc

On Mon, Oct 23, 2023 at 9:07 AM Paulo Alcantara <pc@...guebit.com> wrote:
>
> "Dr. Bernd Feige" <bernd.feige@...klinik-freiburg.de> writes:
>
> > I can confirm that the patches apply cleanly on 6.5.8 and help a lot
> > with the issue here (vers=3.1.1, gentoo client, MS AD server with DFS).
>
> Thanks for testing it.
>
> Steve, I would suggest below commits for v6.5.y
>
>         238b351d0935 ("smb3: allow controlling length of time directory entries are cached with dir leases")
>         6a50d71d0fff ("smb3: allow controlling maximum number of cached directories")
>         2da338ff752a ("smb3: do not start laundromat thread when dir leases  disabled")
>         e95f3f744650 ("smb: client: make laundromat a delayed worker")
>         81ba10959970 ("smb: client: prevent new fids from being removed by laundromat")
>
> If OK, please ask stable team to pick those up.



-- 
Thanks,

Steve