linux-kernel - Re: [PATCH] nvme-keyring: add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Oct 2023 07:24:57 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        linux-nvme@...ts.infradead.org
Subject: Re: [PATCH] nvme-keyring: add MODULE_LICENSE()

On 10/24/23 01:00, Randy Dunlap wrote:
> When NVME_KEYRING=y (NVME_AUTH is not set), there is a modpost build
> error:
> 
> ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o
> 
> so add a MODULE_LICENSE() to keyring.c (copied from auth.c).
> 
> Fixes: 9d77eb527784 ("nvme-keyring: register '.nvme' keyring")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Keith Busch <kbusch@...nel.org>
> Cc: Jens Axboe <axboe@...com>
> Cc: Christoph Hellwig <hch@....de>
> Cc: Sagi Grimberg <sagi@...mberg.me>
> Cc: Hannes Reinecke <hare@...e.de>
> Cc: linux-nvme@...ts.infradead.org
> ---
>   drivers/nvme/common/keyring.c |    2 ++
>   1 file changed, 2 insertions(+)
> 
> diff -- a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
> --- a/drivers/nvme/common/keyring.c
> +++ b/drivers/nvme/common/keyring.c
> @@ -180,3 +180,5 @@ void nvme_keyring_exit(void)
>   	key_put(nvme_keyring);
>   }
>   EXPORT_SYMBOL_GPL(nvme_keyring_exit);
> +
> +MODULE_LICENSE("GPL v2");

Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@...e.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman