[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZTduh5LULBMYf3wq@hovoldconsulting.com>
Date: Tue, 24 Oct 2023 09:13:11 +0200
From: Johan Hovold <johan@...nel.org>
To: Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
Cc: Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Felipe Balbi <balbi@...nel.org>,
Wesley Cheng <quic_wcheng@...cinc.com>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
quic_pkondeti@...cinc.com, quic_ppratap@...cinc.com,
quic_jackp@...cinc.com, ahalaney@...hat.com,
quic_shazhuss@...cinc.com
Subject: Re: [PATCH v13 08/10] arm64: dts: qcom: sc8280xp: Add multiport
controller node for SC8280
On Mon, Oct 23, 2023 at 11:04:38PM +0530, Krishna Kurapati PSSNV wrote:
> On 10/23/2023 9:39 PM, Johan Hovold wrote:
> > On Sat, Oct 07, 2023 at 09:18:04PM +0530, Krishna Kurapati wrote:
> > The interrupt order does not match the binding, where the power event
> > interrupts come first.
> >
> > And we probably also want the hs_phy_irqs here after fixing the
> > incomplete binding.
>
> You want to update the driver code for this as well ? I have no problem
> in adding it in DT and binding but not in driver.
Possibly both.
> >> + usb_2_dwc3: usb@...0000 {
> >> + compatible = "snps,dwc3";
> >> + reg = <0 0x0a400000 0 0xcd00>;
> >> + interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
> >
> > I'd also like to know what that second dwc3 interrupt is for and whether
> > it should be defined here as well.
>
> Second interrupts is for HW acceleration I believe for which support is
> not there currently.
But the interrupt is there. And devicetree describes the hardware, not
the implementation, as I've pointed out before.
Johan
Powered by blists - more mailing lists