linux-kernel - Re: [PATCH v3.1 3/4] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aef93a48cf270d5078ccdc39d95113a4.sboyd@kernel.org>
Date:   Mon, 23 Oct 2023 17:34:33 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>, agross@...nel.org,
        andersson@...nel.org, conor+dt@...nel.org,
        dmitry.baryshkov@...aro.org, jonathan@...ek.ca,
        konrad.dybcio@...aro.org, krzysztof.kozlowski+dt@...aro.org,
        mturquette@...libre.com, quic_tdas@...cinc.com, robh+dt@...nel.org,
        vladimir.zapolskiy@...aro.org
Cc:     linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        bryan.odonoghue@...aro.org
Subject: Re: [PATCH v3.1 3/4] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC

Quoting Bryan O'Donoghue (2023-10-23 08:38:20)
> diff --git a/drivers/clk/qcom/camcc-sc8280xp.c b/drivers/clk/qcom/camcc-sc8280xp.c
> new file mode 100644
> index 000000000000..0631bd5fad57
> --- /dev/null
> +++ b/drivers/clk/qcom/camcc-sc8280xp.c
> @@ -0,0 +1,3048 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2023, Linaro Ltd.
> + */
> +
> +#include <linux/clk-provider.h>
> +#include <linux/err.h>

Is this include used?

> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>

Should be mod_devicetable.h instead?

> +#include <linux/of.h>

Is this include used?

> +#include <linux/pm_clock.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/regmap.h>
> +#include <linux/pm_runtime.h>

This got included twice.

> +
> +#include <dt-bindings/clock/qcom,sc8280xp-camcc.h>
> +
> +#include "clk-alpha-pll.h"