linux-kernel - Re: [PATCH v3 1/6] ACPI: utils: Introduce acpi_dev_uid_match() for matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231024092839.GE3208943@black.fi.intel.com>
Date:   Tue, 24 Oct 2023 12:28:39 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Raag Jadav <raag.jadav@...el.com>
Cc:     rafael@...nel.org, len.brown@...el.com, robert.moore@...el.com,
        andriy.shevchenko@...ux.intel.com, mark.rutland@....com,
        will@...nel.org, linux@...ck-us.net, Jonathan.Cameron@...wei.com,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        acpica-devel@...ts.linuxfoundation.org, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-hwmon@...r.kernel.org,
        mallikarjunappa.sangannavar@...el.com, bala.senthil@...el.com
Subject: Re: [PATCH v3 1/6] ACPI: utils: Introduce acpi_dev_uid_match() for
 matching _UID

On Tue, Oct 24, 2023 at 11:50:13AM +0530, Raag Jadav wrote:
> +/**
> + * acpi_dev_uid_match - Match device by supplied UID
> + * @adev: ACPI device to match.
> + * @uid2: Unique ID of the device.
> + *
> + * Matches UID in @adev with given @uid2.
> + *
> + * Returns:
> + *  - %true if matches.
> + *  - %false otherwise.

Nit: these actually do not get formatted like above so you can just
write it as

Returns: %true in case UIDs match, %false otherwise.

If it is even needed, I think it is pretty obvious from the function
name what it returns.