linux-kernel - Re: [PATCH v2 2/3] arm64: dts: qcom: pm8916: Add BMS and charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9c7f8662e4c02a4f9f275d27469f3be@trvn.ru>
Date:   Tue, 24 Oct 2023 14:29:48 +0500
From:   Nikita Travkin <nikita@...n.ru>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: pm8916: Add BMS and charger

Konrad Dybcio писал(а) 24.10.2023 13:34:
> On 10/23/23 08:20, Nikita Travkin wrote:
>> pm8916 contains some hardware blocks for battery powered devices:
>>
>> - VM-BMS: Battery voltage monitoring block.
>> - LBC: Linear battery charger.
>>
>> Add them to the pmic dtsi so the devices that make use of those blocks
>> can enable them.
>>
>> Signed-off-by: Nikita Travkin <nikita@...n.ru>
>> ---
>>   arch/arm64/boot/dts/qcom/pm8916.dtsi | 48 ++++++++++++++++++++++++++++++++++++
>>   1 file changed, 48 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi
>> index f4de86787743..4b2e8fb47d2d 100644
>> --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi
>> @@ -41,6 +41,35 @@ watchdog {
>>   			};
>>   		};
>>   +		pm8916_charger: charger@...0 {
>> +			compatible = "qcom,pm8916-lbc";
>> +			reg = <0x1000>, <0x1200>, <0x1300>, <0x1600>;
>> +			reg-names = "chgr", "bat_if", "usb", "misc";
>> +
>> +			interrupts = <0x0 0x10 0 IRQ_TYPE_EDGE_BOTH>,
>> +				     <0x0 0x10 5 IRQ_TYPE_EDGE_BOTH>,
>> +				     <0x0 0x10 6 IRQ_TYPE_EDGE_BOTH>,
>> +				     <0x0 0x10 7 IRQ_TYPE_EDGE_BOTH>,
>> +				     <0x0 0x12 0 IRQ_TYPE_EDGE_BOTH>,
>> +				     <0x0 0x12 1 IRQ_TYPE_EDGE_BOTH>,
>> +				     <0x0 0x13 0 IRQ_TYPE_EDGE_BOTH>,
>> +				     <0x0 0x13 1 IRQ_TYPE_EDGE_BOTH>,
>> +				     <0x0 0x13 2 IRQ_TYPE_EDGE_BOTH>,
>> +				     <0x0 0x13 4 IRQ_TYPE_EDGE_BOTH>;
>> +			interrupt-names = "vbat_det",
>> +					  "fast_chg",
>> +					  "chg_fail",
>> +					  "chg_done",
>> +					  "bat_pres",
>> +					  "temp_ok",
>> +					  "coarse_det",
>> +					  "usb_vbus",
> So, both the charger and the USBIN driver use the same irq? :/
> 

AFAIU the usbin extcon driver pretty much just tracks the state
of the IRQ to report extcon. It happens to assume the same part
of the pmic though, yes, which also means there will be no user
that would enable both charger and vbus extcon, since charger
driver provides this functionality as well.

Nikita

> Konrad