linux-kernel - Re: [PATCH net-next 1/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7018bf8b-1f89-408e-8649-3788a28f3b1a@linaro.org>
Date:   Tue, 24 Oct 2023 12:54:52 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Romain Gantois <romain.gantois@...tlin.com>
Cc:     Rob Herring <robh@...nel.org>,
        Luka Perkov <luka.perkov@...tura.hr>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh+dt@...nel.org>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>,
        Russell King <linux@...linux.org.uk>,
        Andy Gross <agross@...nel.org>, davem@...emloft.net,
        thomas.petazzoni@...tlin.com, Paolo Abeni <pabeni@...hat.com>,
        devicetree@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-kernel@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        Bjorn Andersson <andersson@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Robert Marko <robert.marko@...tura.hr>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH net-next 1/5] net: dt-bindings: Introduce the Qualcomm
 IPQESS Ethernet switch

On 24/10/2023 12:05, Romain Gantois wrote:
> On Tue, 24 Oct 2023, Krzysztof Kozlowski wrote:
> 
>> On 24/10/2023 11:54, Romain Gantois wrote:
>>> Hello Rob,
>>>
>>> On Mon, 23 Oct 2023, Rob Herring wrote:
>>>
>>>> pip3 install dtschema --upgrade
>>>>
>>>> Please check and re-submit after running the above command yourself. Note
>>>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>>>> your schema. However, it must be unset to test all examples with your schema.
>>>>
>>>>
>>>
>>> Even after upgrading dtschema to 2023.9, installing yamllint 1.32.0 and running 
>>> without DT_SCHEMA_FILES, I can't seem to reproduce this error. I've also tried 
>>> rebasing on v6.5-rc1 which didn't show it either. However, It seems like 
>>
>> v6.5-rc1 is some ancient version, so how can you rebase on top of it?
> I just cherry-picked this patch series on v6.5-rc1. I also tried v6.6-rc1. Since 
> Rob mentionned basing his series on rc1 in his last message, I inferred that he 
> compiled the dtb checks on the last kernel rc1, but maybe I misunderstood what 
> he meant. 
> 
>>
>> Which commit this is based on?
> 
> This patch series was based on:
> 
> 6e7ce2d71bb9 net: lan966x: remove useless code in lan966x_xtr_irq_handler
> 
> which was the latest commit in net-next/main at the time. Essentially, the patch 
> series is meant to be based on net-next.
> 

Ah, ok.

Rob's bot might be using not-yet-released dtschema from main branch,
thus the error. However the error is true: you added a custom field
without type. That's why I asked: where is it defined?

Best regards,
Krzysztof