linux-kernel - Re: [PATCH net 2/2] liquidio: Simplify octeon_download

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f44e4fd716729f1f35ef58895b1acde53adb9b35.camel@redhat.com>
Date:   Tue, 24 Oct 2023 13:11:13 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        dchickles@...vell.com, sburla@...vell.com, fmanlunas@...vell.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        veerasenareddy.burru@...ium.com
Cc:     felix.manlunas@...ium.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net 2/2] liquidio: Simplify octeon_download_firmware()

On Sun, 2023-10-22 at 22:59 +0200, Christophe JAILLET wrote:
> In order to remove the usage of strncat(), write directly at the rigth
> place in the 'h->bootcmd' array and check if the output is truncated.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> The goal is to potentially remove the strncat() function from the kernel.
> Their are only few users and most of them use it wrongly.
> 
> This patch is compile tested only.

Then just switch to strlcat, would be less invasive.

Thanks,

Paolo