linux-kernel - Re: [PATCH net-next 1/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0389bcc9-b74e-5394-d15a-17914ec3c1a9@bootlin.com>
Date:   Tue, 24 Oct 2023 14:13:17 +0200 (CEST)
From:   Romain Gantois <romain.gantois@...tlin.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
cc:     Romain Gantois <romain.gantois@...tlin.com>,
        Rob Herring <robh@...nel.org>,
        Luka Perkov <luka.perkov@...tura.hr>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh+dt@...nel.org>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>,
        Russell King <linux@...linux.org.uk>,
        Andy Gross <agross@...nel.org>, davem@...emloft.net,
        thomas.petazzoni@...tlin.com, Paolo Abeni <pabeni@...hat.com>,
        devicetree@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-kernel@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        Bjorn Andersson <andersson@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Robert Marko <robert.marko@...tura.hr>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH net-next 1/5] net: dt-bindings: Introduce the Qualcomm
 IPQESS Ethernet switch

On Tue, 24 Oct 2023, Krzysztof Kozlowski wrote:

> Rob's bot might be using not-yet-released dtschema from main branch,
> thus the error. However the error is true: you added a custom field
> without type. That's why I asked: where is it defined?
> 

I didn't define it anywhere, that's an oversight on my part. The psgmii_ethphy 
property is a handle to an MDIO device, which I thought was integrated to the 
PSGMII bus in the IPQ4019. However, I just learned from Robert Marko that this 
MDIO device corresponds to a SoC-facing PHY integrated in the external QCA807x 
IP. Therefore, I'm not convinced that this MDIO device should be handled by 
the ESS driver.

I'm going to have to consider refactoring the psgmii_ethphy handling out of 
the IPQESS driver, which would make this device tree property unnecessary.

Best Regards,

Romain