linux-kernel - Re: [PATCH 3/3] dt-bindings: adis16460: Add 'spi-cs-inactive-delay-ns' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231024132705.00003cf4@Huawei.com>
Date:   Tue, 24 Oct 2023 13:27:05 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     Ramona Gradinariu <ramona.gradinariu@...log.com>,
        <jic23@...nel.org>, <nuno.sa@...log.com>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH 3/3] dt-bindings: adis16460: Add
 'spi-cs-inactive-delay-ns' property

On Mon, 23 Oct 2023 15:22:30 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

> On 23/10/2023 14:35, Ramona Gradinariu wrote:
> > Add 'spi-cs-inactive-delay-ns' property.  
> 
> This we see from the diff. Commit should explain: Why?
> 
> > 
> > Signed-off-by: Ramona Gradinariu <ramona.gradinariu@...log.com>
> > ---
> >  Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > index 4e43c80e5119..3691c0be4f9d 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > @@ -25,6 +25,11 @@ properties:
> >  
> >    spi-cpol: true
> >  
> > +  spi-cs-inactive-delay-ns:
> > +    minimum: 16000
> > +    description:
> > +      If not explicitly set in the device tree, the driver will set it to 16us.  
> 
> Why do you even need it here?

Along side that, if you have a default
default: xxxx
rather than in the description.


> 
> Best regards,
> Krzysztof
> 
>