linux-kernel - Re: [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTe79akvB0OYwG3a@smile.fi.intel.com>
Date:   Tue, 24 Oct 2023 15:43:33 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Rob Herring <robh@...nel.org>, Dhruva Gole <d-gole@...com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        John Ogness <john.ogness@...utronix.de>,
        Johan Hovold <johan@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        Maximilian Luz <luzmaximilian@...il.com>
Subject: Re: [RFC PATCH 1/2] serial: core: Move tty and serdev to be children
 of serial core port device

On Tue, Oct 24, 2023 at 03:17:26PM +0300, Andy Shevchenko wrote:
> On Tue, Oct 24, 2023 at 02:36:18PM +0300, Tony Lindgren wrote:

...

> > -	ctrl->dev.of_node = parent->of_node;
> > +	ctrl->dev.of_node = host->of_node;
> 
> Even above should have been using device_set_node(&ctrl->dev, dev_fwnode(host)).

...

> >  	/* Make sure controller and ResourceSource handle match */
> > -	if (ACPI_HANDLE(ctrl->dev.parent) != lookup.controller_handle)
> > +	if (ACPI_HANDLE(ctrl->host) != lookup.controller_handle)
> 
> This can be changed to use device_match_acpi_handle().
> 
> >  		return -ENODEV;

...

> > -	if (!has_acpi_companion(ctrl->dev.parent))
> > +	if (!has_acpi_companion(ctrl->host))
> 
> I prefer is_acpi_device_node(dev_fwnode(...)) check, but here seems no other
> use for fwnode (haven't checked the full context, though).
> 
> >  		return -ENODEV;

...

I have just sent a little series based on these comments.

-- 
With Best Regards,
Andy Shevchenko