linux-kernel - Re: [PATCH] perf: hisi: Fix use-after-free when register pmu fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169815060330.4017353.11368415377173827667.b4-ty@kernel.org>
Date:   Tue, 24 Oct 2023 13:51:11 +0100
From:   Will Deacon <will@...nel.org>
To:     mark.rutland@....com, jonathan.cameron@...wei.com,
        linux-kernel@...r.kernel.org, Junhao He <hejunhao3@...wei.com>
Cc:     catalin.marinas@....com, kernel-team@...roid.com,
        Will Deacon <will@...nel.org>, linuxarm@...wei.com,
        linux-arm-kernel@...ts.infradead.org, prime.zeng@...ilicon.com,
        yangyicong@...wei.com, shenyang39@...wei.com
Subject: Re: [PATCH] perf: hisi: Fix use-after-free when register pmu fails

On Tue, 24 Oct 2023 19:36:30 +0800, Junhao He wrote:
> When we fail to register the uncore pmu, the pmu context may not been
> allocated. The error handing will call cpuhp_state_remove_instance()
> to call uncore pmu offline callback, which migrate the pmu context.
> Since that's liable to lead to some kind of use-after-free.
> 
> Use cpuhp_state_remove_instance_nocalls() instead of
> cpuhp_state_remove_instance() so that the notifiers don't execute after
> the PMU device has been failed to register.
> 
> [...]

Applied to will (for-next/perf), thanks!

[1/1] perf: hisi: Fix use-after-free when register pmu fails
      https://git.kernel.org/will/c/b805cafc604b

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev