linux-kernel - Re: [PATCH] iosys-map: Rename locals used inside macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <g7y5ivgobnrccjjtdczrj5gcksc5bftutkz4zeeynn6os3rkac@e44pxi6wng43>
Date:   Tue, 24 Oct 2023 08:10:32 -0500
From:   Lucas De Marchi <lucas.demarchi@...el.com>
To:     Michał Winiarski <michal.winiarski@...el.com>
CC:     <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        "Thomas Zimmermann" <tzimmermann@...e.de>
Subject: Re: [PATCH] iosys-map: Rename locals used inside macros

On Tue, Oct 24, 2023 at 01:07:10PM +0200, Michał Winiarski wrote:
>Widely used variable names can be used by macro users, potentially
>leading to name collisions.
>Suffix locals used inside the macros with an underscore, to reduce the
>collision potential.
>
>Suggested-by: Lucas De Marchi <lucas.demarchi@...el.com>
>Signed-off-by: Michał Winiarski <michal.winiarski@...el.com>

`git show --color-words` shows this is doing exactly what it should.

Reviewed-by: Lucas De Marchi <lucas.demarchi@...el.com>

Maybe note in the commit message the compilation error we get with
clang? Although that's in the xe driver that is still not merged
upstream... so not really required.

thanks
Lucas De Marchi