linux-kernel - Re: [PATCH] arm64: dts: cn913x: add device trees for COM Express boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55685b4c-843a-4430-b153-a0eef2e93265@lunn.ch>
Date:   Tue, 24 Oct 2023 16:18:50 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Elad Nachman <enachman@...vell.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, gregory.clement@...tlin.com,
        sebastian.hesselbarth@...il.com, pali@...nel.org,
        mrkiko.rs@...il.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm64: dts: cn913x: add device trees for COM Express
 boards

> +&cp0_mdio {
> +	status = "okay";
> +	pinctrl-0 = <&cp0_ge_mdio_pins>;
> +	phy0: ethernet-phy@0 {
> +		marvell,reg-init = <3 16 0 0x1a4a>;

What does this do? I guess it is something to do with LEDs. Polarity?

> +&cp0_mdio {
> +	status = "okay";
> +	pinctrl-0 = <&cp0_ge_mdio_pins>;
> +	phy0: ethernet-phy@0 {
> +		marvell,reg-init = <3 16 0 0x1a4a>;

I'm temped to NACK this, and get you to work on the LED code in the
Marvell PHY driver and phylib to support what you need. This API is
horrible and should not be used any more.

	Andrew