linux-kernel - Re: [PATCH v4 net-next 1/3] ipv6: drop feature RTAX_FEATURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAO3-Pbohogh1q=20ycPimoPaeAskcAGABvEW=YdZRg3ppRsJ3Q@mail.gmail.com>
Date:   Tue, 24 Oct 2023 09:28:54 -0500
From:   Yan Zhai <yan@...udflare.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Aya Levin <ayal@...dia.com>,
        Tariq Toukan <tariqt@...dia.com>, linux-kernel@...r.kernel.org,
        kernel-team@...udflare.com,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Alexander H Duyck <alexander.duyck@...il.com>
Subject: Re: [PATCH v4 net-next 1/3] ipv6: drop feature RTAX_FEATURE_ALLFRAG

On Tue, Oct 24, 2023 at 5:30 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Tue, Oct 24, 2023 at 12:22 PM Florian Westphal <fw@...len.de> wrote:
> >
> > Yan Zhai <yan@...udflare.com> wrote:
> > >  #define IPCORK_OPT   1       /* ip-options has been held in ipcork.opt */
> > > -#define IPCORK_ALLFRAG       2       /* always fragment (for ipv6 for now) */
> > > +#define IPCORK_ALLFRAG       2       /* (unused) always fragment (for ipv6 for now) */
> >
> > Nit: Why not remove the ALLFRAG define as well?
>
> I agree, this is not exposed to user space and should be deleted.
>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
>
> >
> > Otherwise the series looks good to me, thanks!
> >
> > Reviewed-by: Florian Westphal <fw@...len.de>
> >

I thought there was some convention of not deleting macros. I sent a
V5 to fix this up (not sure if it is the right approach to go) and
carried your review-by tags over since it's just a small change.
Appreciate if there are any more suggestions there.

thanks
Yan