lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 25 Oct 2023 17:25:58 +0200
From:   Dario Binacchi <>
Cc:     Dario Binacchi <>,
        Baolu Lu <>,
        Joerg Roedel <>,
        Jonathan Hunter <>,
        Krishna Reddy <>,
        Robin Murphy <>,
        Thierry Reding <>,
        Will Deacon <>,,
Subject: [PATCH v2] iommu/tegra-smmu: drop error checking for debugfs_create_dir()

The return value of debugfs_create_dir() should be checked using the
IS_ERR() function. The patch, however, drops the check statement without
fixing it because the subsequent functions (i. e. debugfs_create_file())
can handle the case where `@...ent` is an error pointer.

Suggested-by: Baolu Lu <>
Signed-off-by: Dario Binacchi <>


Changes in v2:
 - drop the error checking statement

 drivers/iommu/tegra-smmu.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index e445f80d0226..3e573148d18c 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -1056,9 +1056,6 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients);
 static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu)
 	smmu->debugfs = debugfs_create_dir("smmu", NULL);
-	if (!smmu->debugfs)
-		return;
 	debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu,
 	debugfs_create_file("clients", S_IRUGO, smmu->debugfs, smmu,

Powered by blists - more mailing lists