linux-kernel - Re: [PATCH] rust: kernel: str: Implement Debug for CString

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <hwqyfgbzbnquby5v6zby4u4pbyezzcsttt4ee5x7lw5etpv7se@kvarclpucc7w>
Date:   Wed, 25 Oct 2023 16:18:38 +0000
From:   "Ariel Miculas (amiculas)" <amiculas@...co.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
CC:     Alice Ryhl <aliceryhl@...gle.com>,
        "ariel.miculas@...il.com" <ariel.miculas@...il.com>,
        "alex.gaynor@...il.com" <alex.gaynor@...il.com>,
        "asahi@...ts.linux.dev" <asahi@...ts.linux.dev>,
        "benno.lossin@...ton.me" <benno.lossin@...ton.me>,
        "bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>,
        "boqun.feng@...il.com" <boqun.feng@...il.com>,
        "gary@...yguo.net" <gary@...yguo.net>,
        "lina@...hilina.net" <lina@...hilina.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ojeda@...nel.org" <ojeda@...nel.org>,
        "rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
        "wedsonaf@...il.com" <wedsonaf@...il.com>
Subject: Re: [PATCH] rust: kernel: str: Implement Debug for CString

On 23/07/14 05:01PM, Miguel Ojeda wrote:
> On Fri, Jul 14, 2023 at 4:02 PM Alice Ryhl <aliceryhl@...gle.com> wrote:
> >
> > Adding some sort of motivation usually works quite well, e.g.:
> >
> > Make it possible to use a CString with the `pr_*` macros directly, that
> > is, instead of
> >
> >         pr_debug!("trying to open {:?}\n", &*filename);
> >
> > we can now write
> >
> >         pr_debug!("trying to open {:?}\n", filename);
> 
> Indeed, this would be the most important bit, i.e. answering the "why?".
> 
> The "what?" and the "how?" are pretty much explained by the title, but
> it is also fine giving more details (but if the implementation
> requires an explanation, then it is usually best to write an actual
> source code comment instead).
> 
> Cheers,
> Miguel

Any follow-up on this? It sure would make my logging cleaner.

Cheers,
Ariel