linux-kernel - Re: [PATCH 1/3] dmaengine: sprd: support dma device suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2023 01:46:03 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kaiwei Liu <kaiwei.liu@...soc.com>, Vinod Koul <vkoul@...nel.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@...il.com>
Cc:     oe-kbuild-all@...ts.linux.dev, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, kaiwei liu <liukaiwei086@...il.com>,
        Wenming Wu <wenming.wu@...soc.com>
Subject: Re: [PATCH 1/3] dmaengine: sprd: support dma device suspend/resume

Hi Kaiwei,

kernel test robot noticed the following build warnings:

[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on linus/master v6.6-rc7 next-20231025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kaiwei-Liu/dmaengine-sprd-delete-enable-opreation-in-probe/20231025-201524
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
patch link:    https://lore.kernel.org/r/20231025120500.8914-1-kaiwei.liu%40unisoc.com
patch subject: [PATCH 1/3] dmaengine: sprd: support dma device suspend/resume
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231026/202310260136.yDATuOfv-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231026/202310260136.yDATuOfv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310260136.yDATuOfv-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/dma/sprd-dma.c: In function 'sprd_dma_suspend_noirq':
   drivers/dma/sprd-dma.c:1296:38: error: 'struct dev_pm_info' has no member named 'usage_count'
    1296 |             (atomic_read(&(dev->power.usage_count)) > 1))
         |                                      ^
   drivers/dma/sprd-dma.c: In function 'sprd_dma_resume_early':
   drivers/dma/sprd-dma.c:1305:38: error: 'struct dev_pm_info' has no member named 'usage_count'
    1305 |             (atomic_read(&(dev->power.usage_count)) > 1))
         |                                      ^
   drivers/dma/sprd-dma.c: At top level:
>> drivers/dma/sprd-dma.c:1302:12: warning: 'sprd_dma_resume_early' defined but not used [-Wunused-function]
    1302 | static int sprd_dma_resume_early(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~
>> drivers/dma/sprd-dma.c:1293:12: warning: 'sprd_dma_suspend_noirq' defined but not used [-Wunused-function]
    1293 | static int sprd_dma_suspend_noirq(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~


vim +/sprd_dma_resume_early +1302 drivers/dma/sprd-dma.c

  1292	
> 1293	static int sprd_dma_suspend_noirq(struct device *dev)
  1294	{
  1295		if ((pm_runtime_status_suspended(dev)) ||
  1296		    (atomic_read(&(dev->power.usage_count)) > 1))
  1297			return 0;
  1298	
  1299		return sprd_dma_runtime_suspend(dev);
  1300	}
  1301	
> 1302	static int sprd_dma_resume_early(struct device *dev)
  1303	{
  1304		if ((pm_runtime_status_suspended(dev)) ||
  1305		    (atomic_read(&(dev->power.usage_count)) > 1))
  1306			return 0;
  1307	
  1308		return sprd_dma_runtime_resume(dev);
  1309	}
  1310	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki