linux-kernel - Re: [PATCH] genirq: Own affinity hint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2023 02:48:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jakub Sitnicki <jakub@...udflare.com>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kernel-team@...udflare.com, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Subject: Re: [PATCH] genirq: Own affinity hint

Hi Jakub,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tip/irq/core]
[also build test WARNING on linus/master v6.6-rc7 next-20231025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jakub-Sitnicki/genirq-Own-affinity-hint/20231026-001606
base:   tip/irq/core
patch link:    https://lore.kernel.org/r/20231025141517.375378-1-jakub%40cloudflare.com
patch subject: [PATCH] genirq: Own affinity hint
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231026/202310260237.0IF4S81f-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231026/202310260237.0IF4S81f-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310260237.0IF4S81f-lkp@intel.com/

All warnings (new ones prefixed by >>):

   kernel/irq/irqdesc.c: In function 'alloc_masks':
>> kernel/irq/irqdesc.c:79:1: warning: label 'err_effective_affinity' defined but not used [-Wunused-label]
      79 | err_effective_affinity:
         | ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/irq/irqdesc.c:75:1: warning: label 'err_pending_mask' defined but not used [-Wunused-label]
      75 | err_pending_mask:
         | ^~~~~~~~~~~~~~~~


vim +/err_effective_affinity +79 kernel/irq/irqdesc.c

    68	
    69	#ifdef CONFIG_GENERIC_PENDING_IRQ
    70		if (!zalloc_cpumask_var_node(&desc->pending_mask, GFP_KERNEL, node))
    71			goto err_pending_mask;
    72	#endif
    73		return 0;
    74	
  > 75	err_pending_mask:
    76	#ifdef CONFIG_GENERIC_IRQ_EFFECTIVE_AFF_MASK
    77		free_cpumask_var(desc->irq_common_data.effective_affinity);
    78	#endif
  > 79	err_effective_affinity:
    80		free_cpumask_var(desc->irq_common_data.affinity_hint);
    81	err_affinity_hint:
    82		free_cpumask_var(desc->irq_common_data.affinity);
    83	err_affinity:
    84		return -ENOMEM;
    85	}
    86	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki