linux-kernel - Re: [PATCH 3/6] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-jacuzzi-makomo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJMQK-gkCK=AtSYa7vH5mfD01GedXqd2Hrt1aYPymzOiEr2LRQ@mail.gmail.com>
Date:   Wed, 25 Oct 2023 12:33:03 -0700
From:   Hsin-Yi Wang <hsinyi@...omium.org>
To:     Conor Dooley <conor@...nel.org>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Nícolas F . R . A . Prado 
        <nfraprado@...labora.com>,
        Bernhard Rosenkränzer <bero@...libre.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Macpaul Lin <macpaul.lin@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 3/6] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-jacuzzi-makomo

On Wed, Oct 25, 2023 at 7:49 AM Conor Dooley <conor@...nel.org> wrote:
>
> On Tue, Oct 24, 2023 at 11:22:00AM -0700, Hsin-Yi Wang wrote:
> > On Tue, Oct 24, 2023 at 8:17 AM Conor Dooley <conor@...nel.org> wrote:
> > >
> > > On Mon, Oct 23, 2023 at 05:02:26PM -0700, Hsin-Yi Wang wrote:
> > > > Add makomo sku0 and sku1 which uses different audio codec.
> > > >
> > > > Signed-off-by: Hsin-Yi Wang <hsinyi@...omium.org>
> > > > ---
> > > >  Documentation/devicetree/bindings/arm/mediatek.yaml | 12 ++++++++++++
> > > >  1 file changed, 12 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > > > index fe8c488a3207..b131e0bdbf01 100644
> > > > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > > > @@ -250,6 +250,18 @@ properties:
> > > >                - google,kodama-sku32
> > > >            - const: google,kodama
> > > >            - const: mediatek,mt8183
> > > > +      - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2)
> > > > +        items:
> > > > +          - const: google,makomo-rev4-sku0
> > > > +          - const: google,makomo-rev5-sku0
> > >
> > > With these bindings, how does one describe a makomo-rev5-sku0?
> > > What you have here is only suitable for describing the makomo-rev4-sku0.
> > >
> > makomo-rev5-sku0 and makomo-rev4-sku0 uses the same dts:
> >
> > compatible = "google,makomo-rev4-sku0", "google,makomo-rev5-sku0",
> >                       "google,makomo", "mediatek,mt8183";
> >
> > In this case, can bindings be listed like that?
>
> On a rev5-sku0, the first compatible should be the most specific one,
> which would mean:
>
> compatible = "google,makomo-rev5-sku0", "google,makomo", "mediatek,mt8183";
>
> I said the same on other google laptop bindings before, but I'm not
> really happy with these compatible configurations, that seem conjured up
> to suit your firmware. It'd make far more sense to me to have a setup
> that permitted:
> compatible = "google,makomo-sku0-rev5", "google,makomo-sku0", "google,makomo", "mediatek,mt8183";
> and
> compatible = "google,makomo-sku0-rev4", "google,makomo-sku0", "google,makomo", "mediatek,mt8183";
>

The actual compatible is like:
google,makomo-rev4-sku1 google,makomo-sku1 google,makomo-rev4 google,makomo

So I think I can remove the rev here, and just let them match with
google,makomo-skuX, since rev4/rev5 share the same dts.

> Cheers,
> Conor.
>
> > > > +          - const: google,makomo
> > > > +          - const: mediatek,mt8183
> > > > +      - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2)
> > > > +        items:
> > > > +          - const: google,makomo-rev4-sku1
> > > > +          - const: google,makomo-rev5-sku1
> > > > +          - const: google,makomo
> > > > +          - const: mediatek,mt8183
> > > >        - description: Google Willow (Acer Chromebook 311 C722/C722T)
> > > >          items:
> > > >            - enum:
> > > > --
> > > > 2.42.0.758.gaed0368e0e-goog
> > > >