linux-kernel - Re: [PATCH v7 2/4] riscv: Checksum header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <571211a1-470a-43da-a603-fd12a640b7a8@app.fastmail.com>
Date:   Wed, 25 Oct 2023 23:18:40 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Charlie Jenkins" <charlie@...osinc.com>
Cc:     "Wang, Xiao W" <xiao.w.wang@...el.com>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        "Albert Ou" <aou@...s.berkeley.edu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Conor Dooley" <conor@...nel.org>,
        "David Laight" <David.Laight@...lab.com>,
        "Palmer Dabbelt" <palmer@...belt.com>,
        "Paul Walmsley" <paul.walmsley@...ive.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v7 2/4] riscv: Checksum header

On Wed, Oct 25, 2023, at 23:11, Charlie Jenkins wrote:
>
> Thank you for pointing that out, I had not realized that macro existed.
> Since riscv keeps NET_IP_ALIGN at 0 it should be expected that
> ip_fast_csum is only called with 32-bit aligned addresses. I will update
> the comment and refer to that macro. riscv supports misaligned accesses
> but there are no guarantees of speed.

Just to clarify for your comment: riscv gets the default value of '2',
which is the one that makes the header aligned.

      Arnd