[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20231025143051.6cfe4fc5@kernel.org>
Date: Wed, 25 Oct 2023 14:30:51 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Sabrina Dubroca <sd@...asysnail.net>
Cc: Hangyu Hua <hbh25y@...il.com>, borisp@...dia.com,
john.fastabend@...il.com, davem@...emloft.net, edumazet@...gle.com,
pabeni@...hat.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: tls: Fix possible NULL-pointer dereference in
tls_decrypt_device() and tls_decrypt_sw()
On Wed, 25 Oct 2023 23:20:23 +0200 Sabrina Dubroca wrote:
> There's already a comment above tls_decrypt_sg that (pretty much) says
> out_iov is only used in zero-copy mode.
>
> * [...] The input parameter 'darg->zc' indicates if
> * zero-copy mode needs to be tried or not. With zero-copy mode, either
> * out_iov or out_sg must be non-NULL.
>
> Do we need another just above the call to tls_decrypt_sg?
Sounds good. Right next to a line of code that people will try to
modify when whatever static checker they have tells them this is
buggy :S Call site of tls_decrypt_sg() seems like a good bet.
Powered by blists - more mailing lists